search

synopse / mORMot

Synopse mORMot 1 ORM/SOA/MVC framework - Please upgrade to mORMot 2 !
https://synopse.info
785 stars 323 forks source link

Correct criticalsection managment and move some declaration to handle HttpAPI in Windows. #417

Closed David-Nardi closed 2 years ago

David-Nardi commented 2 years ago

OK, I'me aware to use Git/TortoiseGit so I send an issue.

There is a problem in criticalsection mamagment so I change SynCommons.pas :

And I have move declaration and procedure to handle correctly SSL certificate (I create separate unit to do this) in SynCrtSock.pas

mORMot.zip

synopse commented 2 years ago

Should have been fixed inbetween by https://github.com/synopse/mORMot/commit/136f3b04dac224e50f2f16d1e92c6318601eb0f3

synopse commented 2 years ago

Moving all http.sys declarations into interface part is a huge step, which breaks existing unit layout.

It has been done properly in mORMot 2, and I guess https://github.com/synopse/mORMot2/blob/master/src/lib/mormot.lib.winhttp.pas is what you expect in fact.

But for mORMot 1, I wouldn't do this, it would be confusing for sure for the SynCrtSock unit which is already huge.

Please discuss any further in the forum.