search

synopse / mORMot

Synopse mORMot 1 ORM/SOA/MVC framework - Please upgrade to mORMot 2 !
https://synopse.info
785 stars 323 forks source link

Forward slash instead of backslash? #431

Closed Jawfin closed 2 years ago

Jawfin commented 2 years ago

https://github.com/synopse/mORMot/blob/34bf46e37bb7d2b4dc91adaa4cbdc73e0106a429/SynZip.pas#L1010

I'm no expert, but it seems that last character '\' should be '/'. https://sourceforge.net/p/sevenzip/discussion/45797/thread/30a0833bc9/?limit=25#135d 7Zip doesn't handle the \ and replaces it with a unicode dot instead of handling it as a sub-folder.

synopse commented 2 years ago

It is properly done in mORMOt 2, with a proper ZipNamePathDelim property.

By default, it should be '/' you are right. I have forced the path delimiter to '/' just before writing to disk, as requested by 4.4.17 of reference PKware appnote.

Jawfin commented 2 years ago

Cheers! I just changed that character for mine!! Looking forwards to seeing mORMOt 2 going stable :)

synopse commented 2 years ago

should be good now.

Please reopen a new ticket on any new issuE.