search

syntaxseed / terminalfaker

Terminal Faker - A client-side Linux-like cli terminal simulation written in Javascript. Originally forked from AVGP/terminal.js.
MIT License
51 stars 20 forks source link

Optional config to require a login to access the terminal. #9

Open oskar-kupski-elpassion opened 5 years ago

oskar-kupski-elpassion commented 5 years ago

4

syntaxseed commented 5 years ago

Is this still a work in progress?

Looks great though. I will try it out soon.

oskar-kupski-elpassion commented 5 years ago

My bad, it's not configurable yet. I will add it today tough

On Wed, Oct 2, 2019 at 5:04 PM SyntaxSeed notifications@github.com wrote:

Is this still a work in progress?

  • The username and password should be configurable and password should be hashed.

Looks great though. I will try it out soon.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/syntaxseed/terminalfaker/pull/9?email_source=notifications&email_token=ANLOPPNRFK4DCT3ZAEJROJ3QMS2A5A5CNFSM4I4V4OWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAFCQXQ#issuecomment-537536606, or mute the thread https://github.com/notifications/unsubscribe-auth/ANLOPPPQ4RMSU53DDKRVY53QMS2A5ANCNFSM4I4V4OWA .

oskar-kupski-elpassion commented 5 years ago

Hi, I moved, the configuration of username and password to index.html file. If they are not defined and login is required an error is thrown. Please let me know if it meets your expectations now :)

syntaxseed commented 5 years ago

Note that PR #13 will be merged before the others once it is fully reviewed. This one may need a rebase at that time.

Thanks!

syntaxseed commented 5 years ago

Please rebase & test now that a major refactor has been merged. Thanks!