search

szilard / GBM-perf

Performance of various open source GBM implementations
MIT License
213 stars 28 forks source link

use CLI flags instead of sed for LightGBM GPU install #45

Closed jameslamb closed 3 years ago

jameslamb commented 3 years ago

{lightgbm}'s CMake-based build (the non-CRAN one) no longer requires manually changing variables in R-package/install.libs.R. As of https://github.com/microsoft/LightGBM/pull/3574, you can pass flags like Rscript build_r.R --use-gpu.

This PR proposes changing the dockerfiles in this project to use that strategy, since it's less likely to be broken by future changes to {lightgbm}.

szilard commented 3 years ago

Thanks, James.

jameslamb commented 3 years ago

no prob! I'm trying to find this sed pattern on GItHub today and make PRs everywhere, so people's search results for "LightGBM R on GPU" leads them to the command-line args.

szilard commented 3 years ago

Awesome, great idea 👍