taarifa / taarifa_backend

Prototype of a Taarifa backend (DEPRECATED, use TaarifaAPI)
Other
0 stars 1 forks source link

Merging the 'map' branch with master #7

Closed markiliffe closed 10 years ago

markiliffe commented 10 years ago

These two commits add a map visualisation of the waterponts. #efdee02 integrates a Leaflet.js map, whereas #b222139 integrates the clustering.

kynan commented 10 years ago

@markiliffe I rewrote the branch to fix some issues, partly formatting, like tabs etc.

I don't quite understand why you're loading the Map on the home page via the Map nav button instead of just adding a separate route for it. In particular since you can't currently hide the map again. It also means we're pulling in a jQuery dependency for not much benefit imho. @dgorissen?

dgorissen commented 10 years ago

To summarise:

Marker colours are not yet dynamic on the water point status as that info is not yet in the db. Once that info is in the db, this is trivial to change on the ui side.

kynan commented 10 years ago

@dgorissen Can we load those assets from CDN rather than including them in the repo?

markiliffe commented 10 years ago

We can, I’ll update the links as much as I can and document.

kynan commented 10 years ago

OK, that's all done now, I've rewritten the branch. @nicowe has also fixed the JS formatting.