Docker updates - Githubissues

tagyoureit / nodejs-poolController-webClient

Web app for nodejs-poolController 6.0 and above.

GNU Affero General Public License v3.0

9 stars 4 forks source link

Docker updates #16

Closed emes closed 3 years ago

emes commented 3 years ago

Dockerfile for webClient

tagyoureit commented 3 years ago

@andylippitt @emes I'm not the best resource on Docker files. Could you guys figure out what's the best approach (sans VCC)? Not sure if accepting this PR puts both of your changes at odds with each other or if they are fully compatible. Thx.

emes commented 3 years ago

They accomplish the same thing/are compatible. When @andylippitt noted the ~1GB size of the docker image, I switched to a thinner base image and a multistage build which attempts to bring over only what's needed. This results in a docker image which is ~270MB which seems a bit more reasonable. Would love @andylippitt's thoughts.