Adds weekly benchmarks, tencent test run - Githubissues

taikoxyz / zkevm-circuits

DEPRECATED in favor of https://github.com/taikoxyz/raiko! Taiko's fork of the PSE's ZK-EVM

Other

159 stars 125 forks source link

Adds weekly benchmarks, tencent test run #135

Closed krzysztofpaliga closed 1 year ago

krzysztofpaliga commented 1 year ago

Description

This PR adds the support for:

running weekly circuit benchmarks on Tencent Cloud, triggered by Github Actions
running on demand arbitrary test commands on Tencent Cloud, triggered manually by using Github Actions

Issue Link

[link issue here]

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Contents

.github/workflows/weekly-bench.yml
.github/workflows/cloud-run.yml
.github/weeklyBenchScripts/*
.github/cloudRun/*

Rationale

Since both circuit benchmarks and circuit tests require a large amount of memory, it is best to have them running in the Cloud.

How Has This Been Tested?

By running through multiple times.

pbeza commented 1 year ago

FWIW - that's a nitpick, but I can see copy-pasted 43.130.90.57 in multiple files. Supposedly, this is the IP address of the Tencent Cloud virtual server we use for testing. Maybe it's worth having it defined only in one place? (e.g. using GitHub secrets? same as with BENCH_RESULTS_PASS). Just a suggestion though.