taiwangoldcard / website

Taiwan Gold Card Community website
https://taiwangoldcard.com
Other
43 stars 18 forks source link

Release bot goes into infinite loop #144

Closed geekyme closed 4 years ago

geekyme commented 4 years ago

Context:

Ref https://github.com/taiwangoldcard/website/pull/143, this change was commited in an attempt to make the bot release changes made from PR forks.

The secrets configured on this repo correctly propagate to the bot, however the bot goes into a release loop:

Screenshot 2020-09-26 at 4 19 35 PM

If we use:

on:
  pull_request:
    branches:
      - master
    types: [closed]

the loop will be gone but the bot only gets the secrets if the PR is NOT opened from a fork. Looking for suggestions to fix this without removing branch protection.

geekyme commented 4 years ago

https://github.community/t/workflow-infinite-loop/16547/3

Similar issue

geekyme commented 4 years ago

Looks like this could work hmmm

if: github.actor != 'my_bot_account'

matrinox commented 4 years ago

Looks like this could work hmmm

if: github.actor != 'my_bot_account'

Did this work?

geekyme commented 4 years ago

Haven't tried @matrinox , not at my desk. You wanna try?

geekyme commented 4 years ago

Fixed! @matrinox