search

taiwangoldcard / website

Taiwan Gold Card Community website
https://taiwangoldcard.com
Other
43 stars 18 forks source link

#147 added prettier configuration file for automated code formatting #160

Closed RohitDhatrak closed 3 years ago

RohitDhatrak commented 4 years ago

Added prettier configuration file for automated code formatting to maintain uniformity in the code

geekyme commented 4 years ago

Thanks for this! how does this work? is there something we have to install before the code formatting kicks in?

erickhun commented 4 years ago

Same question as @geekyme I'm pretty behind when it comes to linters. I use vscode on that project and I think others might use different text editors. How will that work?

RohitDhatrak commented 4 years ago

@geekyme @erickhun Yes you'll need prettier you can list that in the contributuion guide as a requirement I have seen many repositories doing so to maintain a format.

matrinox commented 4 years ago

@RohitDhatrak What do you think of adding this prettier check? https://github.com/marketplace/actions/prettier-action?version=v3.0 That way we can enforce prettier

RohitDhatrak commented 4 years ago

@matrinox yes this is a good alternative!

geekyme commented 4 years ago

Nice find @matrinox, could you modify the GitHub actions workflow code in the repo for this @RohitDhatrak ?

RohitDhatrak commented 4 years ago

@geekyme Yes I'll create a new .yml file for prettier. Should I do it for the pull request as well or just push?

johncliu commented 3 years ago

What's the status of this PR? Merge or close?

matrinox commented 3 years ago

Let's merge anyways since it's net positive