Closed peterwcm closed 2 years ago
Excellent @peterwcm ! wondering if that'd be easy to support the dark mode too ?
This is very cool.
Excellent @peterwcm ! wondering if that'd be easy to support the dark mode too ?
Something like this maybe?
@peterwcm hmm, kinda like the 1st version (whit bg) better. But I feel like 2nd version would be more consistent with the "dark mode" of the other pages in the website?
perhaps @bdon @matrinox or @iansinnott would have a better opinion than mine?
I'll trust your decision @peterwcm
@erickhun @peterwcm If I had to choose, I'd go with option 2 as it does fit dark mode better.
@peterwcm Great work DRYing the gold card holder sections!
Thank you Geoffrey for reviewing the code! @erickhun I think excluding myself, most people are in favour of the white bg so I have updated it to use #eee with dark text for now. Please help with the merge & deploy and let me know if there is anything else I could help with to get this moving 😄
Changelog:
goldcardholder
shortcode to separate its design from the contents, and improve reusabilitycard
andgold-card-holder