search

taiwangoldcard / website

Taiwan Gold Card Community website
https://taiwangoldcard.com
Other
43 stars 18 forks source link

Community Page Redesign #240

Closed peterwcm closed 2 years ago

peterwcm commented 2 years ago

Changelog:

erickhun commented 2 years ago

Excellent @peterwcm ! wondering if that'd be easy to support the dark mode too ? Screen Shot 2022-06-17 at 4 51 46 PM

fifieldt commented 2 years ago

This is very cool.

peterwcm commented 2 years ago

Excellent @peterwcm ! wondering if that'd be easy to support the dark mode too ? Screen Shot 2022-06-17 at 4 51 46 PM

Something like this maybe? image

erickhun commented 2 years ago

@peterwcm hmm, kinda like the 1st version (whit bg) better. But I feel like 2nd version would be more consistent with the "dark mode" of the other pages in the website?

perhaps @bdon @matrinox or @iansinnott would have a better opinion than mine?

I'll trust your decision @peterwcm

matrinox commented 2 years ago

@erickhun @peterwcm If I had to choose, I'd go with option 2 as it does fit dark mode better.

@peterwcm Great work DRYing the gold card holder sections!

peterwcm commented 2 years ago

Thank you Geoffrey for reviewing the code! @erickhun I think excluding myself, most people are in favour of the white bg so I have updated it to use #eee with dark text for now. Please help with the merge & deploy and let me know if there is anything else I could help with to get this moving 😄