search

taj-ny / kwin-effects-forceblur

Fork of the KWin Blur effect for KDE Plasma 6 with additional features (including force blur) and bug fixes
GNU General Public License v3.0
165 stars 10 forks source link

Rounded corner effect doesn't work well on KDE-Rounded-Corners #34

Open queenbiscuit311 opened 5 months ago

queenbiscuit311 commented 5 months ago

I've been using this effect for a little while on plasma 6 and while it's great, there's something about it that annoys me. If you use lightlyshaders and set the blur roundness to the same radius as lightlyshaders, everything looks pretty much identical to if I was using the lightlyshaders blur. However, lightlyshaders shadows look really ugly on my theme, so I'm using KDE-Rounded-Corners. But when using that effect, the rounding doesn't quite look right. When using 12px window rounding and 12px blur rounding, it gives this weird beveled edge effect that doesn't quite look right.

image

KDE-Rounded-Corners

image

LightlyShaders

Setting blur radius to 14px makes it look better, but in certain situations it is quite obvious that the blur radius is smaller than the window radius.

image

It's a very minor issue but I thought it would be a good idea to make an issue for it.

taj-ny commented 4 months ago

I changed the position of this effect in the effect chain in order to make it run after KDE-Rounded-Corners/LightlyShaders and it's very glitchy, but the blur region is rounded and looks very nice. I should be able to reuse the shader from one of these projects. The catch is that the corners will be rounded twice - once for the blur region and once for the window.

taj-ny commented 4 months ago

I couldn't get KDE-Rounded-Corners' shader to work, so I used a different one. Here's the best result I've been able to achieve with a 12px window radius. image

With slightly more antialiasing: image

Without antialiasing for comparison: image

Still not perfect, but in my opinion it's better than before.

queenbiscuit311 commented 4 months ago

that is definitely looking much better than before! would be happy to test if needed

taj-ny commented 3 months ago

Partially fixed in v1.3.0. Looks much better but still not perfect. I could probably make it look perfect by blending the window texture with the blur, which would allow KDE-Rounded-Corners/LightlyShaders to also round the blur region, but the side effect would be blurry windows when using scaling even without rounded corners.