search

tamton-aquib / staline.nvim

A modern lightweight statusline and bufferline plugin for neovim in lua.
MIT License
380 stars 17 forks source link

Fix icons for nerd-fonts 3.0 update #56

Closed cronyakatsuki closed 12 months ago

cronyakatsuki commented 1 year ago

With the new nerd font's 3.0 update, material icon font's were moves, leaving empty boxes in their place.

This pull request hopes to fix that.

tamton-aquib commented 12 months ago

Heyyo @cronyakatsuki,

Thats a fine addition 👍🏻 . But before merging I wanted to ask, if this change would break for people who are still on 2.0 or before?

cronyakatsuki commented 12 months ago

Heyyo @cronyakatsuki,

Thats a fine addition 👍🏻 . But before merging I wanted to ask, if this change would break for people who are still on 2.0 or before?

Hello, sorry for late reply.

From what I know nerd fonts had to change where the font icons were placed, material icon to be exact cause they were in space for other icons.

Based on that, depending on the icon it might work for 2.0 or not.

There could be added a note in readme about it. Since it has already been almost 6 months since 3.0 update came out.

tamton-aquib commented 12 months ago

Sounds good.

Thank you so much for this PR ❤️