search

tamton-aquib / staline.nvim

A modern lightweight statusline and bufferline plugin for neovim in lua.
MIT License
373 stars 16 forks source link

Add highlight in mode and progress sections #7

Closed laraib07 closed 3 years ago

laraib07 commented 3 years ago

Liked your work.

Please consider adding highlight ( make font bold ) in mode and progress sections.

tamton-aquib commented 3 years ago

Heyyo @laraib07, sorry for the late response haha 😅.

And yes, adding highlights would be really nice. Will probably start soon. Also, I'm working on sections in the beta branch (just testing things out).

laraib07 commented 3 years ago

Thank you for all your hard work on this 🙂.

tamton-aquib commented 3 years ago

heyyo @laraib07, I've merged beta to main.

Added sections. (wont break previous configs), but filename_section in defaults is deprecated. Added the highlight stuff. give it as {highlight_group, section_name}.

Havent updated some stuff in readme. Will do it later. In the mean time, feel free to try the new changes 😅

laraib07 commented 3 years ago

Thanks for your work again 😄. I tried the new update. I believe fonts can be more bold. And there is another issue I am facing, don't know if its because of my configs. I am using edited Nvchad configs and previously used lualine. Now when using staline and setting laststatus=2, the statusline doesn't appear on startup, I have to toggle NvimTree twice (which behind the scene set laststatus to 0 and then to 2) to make it appears on the screen.

I haven't faced this issue with lualine on same configs.

tamton-aquib commented 3 years ago

Hey @laraib07, sorry for all these silly bugs.

I am using edited Nvchad configs and previously used lualine. Now when using staline and setting laststatus=2, the statusline doesn't appear on startup, I have to toggle NvimTree twice (which behind the scene set laststatus to 0 and then to 2) to make it appears on the screen

The problem was, I didn't account for the lazy loading stuff that everybody is doing nowadays. So I've added the BufReadPost autocmd in the latest commit. Now it will show up when opening a normal buffer. (without extra performance cost)

I believe fonts can be more bold.

have u tried setting defaults = { font_active = "bold" }. or maybe "bold,italic" because by default it is "none".

laraib07 commented 3 years ago

have u tried setting defaults = { font_active = "bold" }. or maybe "bold,italic" because by default it is "none".

Now its perfect 😄😄. The issue is resolved too. Thanks

Edit: Facing same issue with branch section only now.

tamton-aquib commented 3 years ago

Gosh.... I don't know how i miss these small things 😅

Fixed btw. And sorry for the inconveniences (again haha).

laraib07 commented 3 years ago

I don't mind the inconveniences. I fully understand the effort goes behind these projects and I appreciate it.

Still facing the same issue Branch name appears only after toggling nvimtree twice.

tamton-aquib commented 3 years ago

Added BufReadPost to update_branch() as well.

Also added some extra normal modes because j and k felt a little glitchy in NvChad. Probably because they are mapped to gj and gk, which enters an intermediate normal mode, i guess.

laraib07 commented 3 years ago

The issue is resolved now🙂. Will inform if I encounter any other bug.

tamton-aquib commented 3 years ago

Perfect. And thanks again for reporting all these. I've actually seen some improvement in performance too.

Closing this issue for now. Feel free to open if there are any similar issues.