search

tautcony / ISTA-Patcher

An IL patcher
GNU General Public License v3.0
37 stars 14 forks source link

4.44.1x update crashes on startup #14

Closed itstheodor closed 1 year ago

itstheodor commented 1 year ago

Describe the bug Starting with update 4.44.1x, it seems BMW is starting to roll out some kind of authentication in ISTA. A quick look inside "RheingoldPresentationFramework" shows the BMW.Rheingold.PresentationFramework.Authentication class. I am not sure if it was there before, but that is where it crashes according to the logs (see uploads).

To Reproduce Steps to reproduce the behavior:

  1. Try launching ISTA 4.44.11

Logs If applicable, upload logs under ISTA\Logs to help troubleshoot your problem (emptying the Logs folder and reproducing the problem before uploading them would be more helpful in analyzing the logs). 20231030_031302_953b5ad6-bad3-464b-a941-6526f274fa05_IstaServicesHost.log 20231030_ISTA.log

Desktop (please complete the following information):

tautcony commented 1 year ago

Yes, this class was not there before, as I haven't got the 4.44.11 version yet, could you please upload the TesterGUI folder for further investgation?

tautcony commented 1 year ago

Try the version from new branch.

Authentication here refers to the authentication of its online account system, which should be an unnecessary part here, corresponding function has been patched. But I'm not sure if there's still some blocking points behind it.

itstheodor commented 1 year ago

Still crashes at BMW.Rheingold.PresentationFramework.Authentication.UserEnvironmentProvider.GetCurrentNetworkType

20231030_192135_b19c0c2e-8968-413b-a62c-980d2073f2ed_IstaServicesHost.log 20231030_ISTA.log

itstheodor commented 1 year ago

Made a short & quick PR. It now launches successfully and no errors are logged so far. Will try connecting to the car later, but it should work. Should investigate further if those new authentication features affect any other areas of the app. Would be pretty bad for it to crash, for instance, during programming.

itstheodor commented 1 year ago

Tested on my F30 using ENET. Works OK, connected successfully, vehicle test worked & was able to do some basic ops (delete fault memory). I consider this closed after merging.

tautcony commented 1 year ago

After comparing codes with version 4.43, in addition to the above, making sure that config BMW.Rheingold.Auth.Enabled is set to false should be fine (which is set to false in code by default).

itstheodor commented 1 year ago

Yes, I set that to false. Should it be added to the README?