tautcony / ISTA-Patcher

An IL patcher
GNU General Public License v3.0
17 stars 8 forks source link

Latest version supported? #2

Closed CharlesJung73 closed 1 year ago

CharlesJung73 commented 1 year ago

I tried using ISTA-Patcher in ISTA 4.39.2x, but it doesn't run normally and there is an error.

Do you have any plans to update ISTA-Patcher to support the latest version?

ISTA Error

tautcony commented 1 year ago

Currently the latest version I can get is 4.37.4x, I will verify that later.

For 4.39.2x, you need to provide a torrent or download link.

CharlesJung73 commented 1 year ago

When I heard that another friend succeeded, I tested it on another PC and it worked well.

I will test the diagnosis and programming when I have time.

I'll use it thankfully! :)

tautcony commented 1 year ago

Diagnostics I tested is working, but programming initialization will failed, you can also try it.

Maybe I need to refactor the patch method to make each function work properly.

CharlesJung73 commented 1 year ago

Here are two download links of ISTA StandAlone 4.39.2x.

[removed]

I hope it helps you with your patch work.

CharlesJung73 commented 1 year ago

There is an error when diagnosing.

I couldn't even try to update the firmware.

ISTA Error 01 ISTA Error 02
tautcony commented 1 year ago

Yes, the programming module still need more investigation to make it work properly.

xpnglitch commented 1 year ago

i think i know why programming isnt working, ive checked through the logs. i beleive the reason is due to the dealerID and another (distributionID? cant remember the name of the second ID) being 00... in pzdsdata logs it fails to load due to the 2 IDs being zero... usually with earlier versions you would set dealerID to 1 after inserting license. hope this helps, as i dont have the knowledge to find out where to change this :)

tautcony commented 1 year ago

    private static String generateOrganizationId(int dealerId, int plantId) {
        String organizationId;
        if (dealerId == 0) {
            if (plantId == 0) {
                throw new PSdZArgumentException(PSdZErrorCodes.DEALER_ID_AND_PLANT_ID_MUST_NOT_BOTH_BE_0);
            }
            organizationId = Integer.toString(plantId, 16);
        } else if (plantId != 0) {
            throw new PSdZArgumentException(PSdZErrorCodes.EXACTLY_ONE_OF_DEALER_ID_AND_PLANT_ID_MUST_BE_0);
        } else {
            organizationId = Integer.toString(dealerId, 16);
        }
        return organizationId;
    }

According to the error message shown in psdz-core.jar file, I made a manual patch to PsdzServiceImpl.dll(4.39.20), which set DealerID to "1234" and plantID to "0", This may work or not.

Since this error is thrown by the psdz(which is a java application), if this patch does not work, may need to patch psdz-core.jar to bypass this check.

patch-psdz.zip

xpnglitch commented 1 year ago

wow that was quick!! :) ill test it out im actually testing this on 4.38.3x do you think it willl be backwards compatible?

tautcony commented 1 year ago

wow that was quick!! :) ill test it out im actually testing this on 4.38.3x do you think it willl be backwards compatible?

at least the PsdzServiceImpl.dll version upgrade in each release, it may not work.

If this method works, I would add it to the patcher to make it work in multiple version.

xpnglitch commented 1 year ago

ok, ill have to download 4.39... should have a bmw to test on tomorrow

xpnglitch commented 1 year ago

ok, i wasnt able to test with 4.39... but using it with 4.38 has definitely done something.... it do longer throws the error in the logs... but as you suspected it throws a db error.

here is the same file but from 4.38.. my ista download wont finish anytime soon

PsdzServl.zip

tautcony commented 1 year ago

@xpnglitch try this Psdz-v1.8.zip

xpnglitch commented 1 year ago

ok, will try now

xpnglitch commented 1 year ago

had issues with my 4.38 install... going to try 4.39 in about an hour or so, as i finshed installing it

xpnglitch commented 1 year ago

@tautcony confirmed working

tautcony commented 1 year ago

@tautcony confirmed working

thanks for the test, i'll work on adding it to this patcher.

iggy2022 commented 1 year ago

thank for your great work months of work for an incredible result good work

CharlesJung73 commented 1 year ago

@xpnglitch try this Psdz-v1.8.zip

Which of the three folders below should I apply the Psdz-v1.8.zip file to?

  1. PSdZ\host
  2. PSdZ\host64
  3. TesterGUI\bin\Release\Release
tautcony commented 1 year ago

That file is for 4.38, host or host64 i think.