Patch needs to be executed twice when drive letter in path is lowercase

[rocdeng]

Describe the bug Patch needs to be executed twice when drive letter in path is lowercase , first time all files will be skipped, 2nd time files will be patched. the commandlines are all the same. If the drive letter is uppercase, the files will be patched everytime correctly.

To Reproduce Just execute the patch with lowercase drive letter, like ISTA-Patcher.exe patch --enable-enet "c:\Program Files (x86)\BMW\ISPI\TRIC\ISTA" Logs:

D:\Downloads\ISTA-Patcher-win-x64-Release-1.1.1>ISTA-Patcher.exe patch --enable-enet "c:\Program Files (x86)\BMW\ISPI\TRIC\ISTA"
[05:50:08 INF] === ISTA Patch Begin ===
[05:50:08 INF] AirCallServices.dll                        ------------------- [skip]
[05:50:08 INF] AirCommon.dll                              ------------------- [skip]
[05:50:08 INF] AirForkServices.dll                        ------------------- [skip]
[05:50:08 INF] BMW.ISPI.Puk.Decentral.PukBasicData.dll    ------------------- [skip]
[05:50:08 INF] BMW.ISPI.Puk.Decentral.PukVCLib.dll        ------------------- [skip]
[05:50:08 INF] BMW.ISPI.Puk.Decentral.VehicleCaseData.dll ------------------- [skip]
[05:50:08 INF] BMW.ISPI.TRIC.ISTA.MultisourceLogic.dll    ------------------- [skip]
[05:50:08 INF] BMW.Rheingold.SvgViewer.dll                ------------------- [skip]
[05:50:08 INF] BMW.VDPM.Conwoy.Api.Client.dll             ------------------- [skip]
[05:50:08 INF] COAPILib.dll                               ------------------- [skip]
[05:50:08 INF] COAPILib32v4.0.dll                         ------------------- [skip]
[05:50:08 INF] CommonServiceSec.dll                       ------------------- [skip]
[05:50:08 INF] CryptoLib.dll                              ------------------- [skip]
[05:50:08 INF] DiagnosticsBusinessData.dll                ------------------- [skip]
[05:50:08 INF] FscValidationContract.dll                  ------------------- [skip]
[05:50:08 INF] IAirCallServices.dll                       ------------------- [skip]
[05:50:08 INF] IAirForkServices.dll                       ------------------- [skip]
[05:50:08 INF] IstaOperationContract.dll                  ------------------- [skip]
[05:50:08 INF] IstaServicesContract.dll                   ------------------- [skip]
[05:50:08 INF] IstaServicesController.dll                 ------------------- [skip]
[05:50:08 INF] psdz-api.j4n.dll                           ------------------- [skip]
[05:50:08 INF] PsdzServiceClient.dll                      ------------------- [skip]
[05:50:08 INF] PsdzServiceContract.dll                    ------------------- [skip]
[05:50:08 INF] RheingoldCoreBootstrap.dll                 ------------------- [skip]
[05:50:08 INF] RheingoldCoreContracts.dll                 ------------------- [skip]
[05:50:08 INF] RheingoldDatabasePostgreSQLConnector.dll   ******************* [not found]
[05:50:08 INF] RheingoldFASTAConfigParsing.dll            ------------------- [skip]
[05:50:08 INF] RheingoldIDES.dll                          ------------------- [skip]
[05:50:08 INF] RheingoldInfoProvider.XmlSerializers.dll   ------------------- [skip]
[05:50:08 INF] RheingoldKMM.dll                           ------------------- [skip]
[05:50:08 INF] RheingoldMeasurementCommon.dll             ------------------- [skip]
[05:50:08 INF] RheingoldOperationsReportConverter.dll     ------------------- [skip]
[05:50:09 INF] RheingoldProcessCommunicationBase.dll      ------------------- [skip]
[05:50:09 INF] RheingoldSharpVectorSvgViewer.dll          ------------------- [skip]
[05:50:09 INF] TestAutomationCore.dll                     ------------------- [skip]
[05:50:09 INF]                                            ││││││││││││││││││└>[InteractionAdministrationModel]
[05:50:09 INF]                                            │││││││││││││││││└─>[ConfigurationService]
[05:50:09 INF]                                            ││││││││││││││││└──>[ServiceProgramCompilerLicense]
[05:50:09 INF]                                            │││││││││││││││└───>[PackageValidityService]
[05:50:09 INF]                                            ││││││││││││││└────>[IstaProcessStarter]
[05:50:09 INF]                                            │││││││││││││└─────>[IstaIcsServiceClient]
[05:50:09 INF]                                            ││││││││││││└──────>[VerifyAssemblyHelper]
[05:50:09 INF]                                            │││││││││││└───────>[IntegrityManager]
[05:50:09 INF]                                            ││││││││││└────────>[TherapyPlanCalculated]
[05:50:09 INF]                                            │││││││││└─────────>[ActivationCertificateHelper]
[05:50:09 INF]                                            ││││││││└──────────>[MainWindowViewModel]
[05:50:09 INF]                                            │││││││└───────────>[FscValidationClient]
[05:50:09 INF]                                            ││││││└────────────>[SecureAccessHelper]
[05:50:09 INF]                                            │││││└─────────────>[CommonServiceWrapper]
[05:50:09 INF]                                            ││││└──────────────>[LicenseAOSManager]
[05:50:09 INF]                                            │││└───────────────>[LicenseHelper]
[05:50:09 INF]                                            ││└────────────────>[LicenseManager]
[05:50:09 INF]                                            │└─────────────────>[LicenseWizardHelper]
[05:50:09 INF]                                            └──────────────────>[LicenseStatusChecker]
[05:50:09 INF] === ISTA Patch Done in 00:00 ===

D:\Downloads\ISTA-Patcher-win-x64-Release-1.1.1>"patch Program.bat"

D:\Downloads\ISTA-Patcher-win-x64-Release-1.1.1>ISTA-Patcher.exe patch --enable-enet "c:\Program Files (x86)\BMW\ISPI\TRIC\ISTA"
[05:50:20 INF] === ISTA Patch Begin ===
[05:50:21 INF] !PSdZ/host/PsdzServiceImpl.dll             -----------------1- [1 func patched]
[05:50:21 INF] !PSdZ/hostx64/PsdzServiceImpl.dll          -----------------1- [1 func patched]
[05:50:21 INF] AirCallServices.dll                        ------------------- [skip]
[05:50:21 INF] AirCommon.dll                              ------------------- [skip]
[05:50:21 INF] AirForkServices.dll                        ------------------- [skip]
[05:50:21 INF] Authoring.dll                              11311-------------- [7 func patched]
[05:50:21 INF] BMW.ISPI.Puk.Decentral.PukBasicData.dll    ------------------- [skip]
[05:50:21 INF] BMW.ISPI.Puk.Decentral.PukVCLib.dll        ------------------- [skip]
[05:50:21 INF] BMW.ISPI.Puk.Decentral.VehicleCaseData.dll ------------------- [skip]
[05:50:21 INF] BMW.ISPI.TRIC.ISTA.MultisourceLogic.dll    ------------------- [skip]
[05:50:21 INF] BMW.Rheingold.SvgViewer.dll                ------------------- [skip]
[05:50:21 INF] BMW.VDPM.Conwoy.Api.Client.dll             ------------------- [skip]
[05:50:21 INF] COAPILib.dll                               ------------------- [skip]
[05:50:21 INF] COAPILib32v4.0.dll                         ------------------- [skip]
[05:50:22 INF] CommonServices.dll                         ------1--2--------- [3 func patched]
[05:50:22 INF] CommonServiceSec.dll                       ------------------- [skip]
[05:50:22 INF] CryptoLib.dll                              ------------------- [skip]
[05:50:22 INF] DiagnosticsBusinessData.dll                ------------------- [skip]
[05:50:22 INF] FscValidationClient.dll                    -------1----------- [1 func patched]
[05:50:22 INF] FscValidationContract.dll                  ------------------- [skip]
[05:50:22 INF] IAirCallServices.dll                       ------------------- [skip]
[05:50:22 INF] IAirForkServices.dll                       ------------------- [skip]
[05:50:22 INF] ISTAGUI.exe                                11311---1--1---1--- [10 func patched]
[05:50:22 INF] IstaOperation.exe                          -----------1------- [1 func patched]
[05:50:22 INF] IstaOperationContract.dll                  ------------------- [skip]
[05:50:22 INF] IstaOperationController.dll                113-1-------------- [6 func patched]
[05:50:22 INF] IstaOperationImpl.dll                      11311------1------- [8 func patched]
[05:50:23 INF] IstaServicesClient.dll                     -------------1----- [1 func patched]
[05:50:23 INF] IstaServicesContract.dll                   ------------------- [skip]
[05:50:23 INF] IstaServicesController.dll                 ------------------- [skip]
[05:50:23 INF] IstaServicesHost.exe                       -----------1------- [1 func patched]
[05:50:23 INF] IstaServicesImpl.dll                       11311------1------- [8 func patched]
[05:50:23 INF] psdz-api.j4n.dll                           ------------------- [skip]
[05:50:23 INF] PsdzServiceClient.dll                      ------------------- [skip]
[05:50:23 INF] PsdzServiceContract.dll                    ------------------- [skip]
[05:50:23 INF] PsdzServiceImpl.dll                        -----------------1- [1 func patched]
[05:50:23 INF] RGSPC.exe                                  11311-------------- [7 func patched]
[05:50:23 INF] RheingoldCoreBootstrap.dll                 ------------------- [skip]
[05:50:23 INF] RheingoldCoreContracts.dll                 ------------------- [skip]
[05:50:24 INF] RheingoldCoreFramework.dll                 ------------1-1---1 [3 func patched]
[05:50:24 INF] RheingoldDatabaseOracleConnector.dll       11311-------------- [7 func patched]
[05:50:24 INF] RheingoldDatabasePostgreSQLConnector.dll   ******************* [not found]
[05:50:24 INF] RheingoldDatabaseSQLiteConnector.dll       11311-------------- [7 func patched]
[05:50:26 INF] RheingoldDiagnostics.dll                   11311-------------- [7 func patched]
[05:50:26 INF] RheingoldExternalToolLicense.dll           ----------------1-- [1 func patched]
[05:50:26 INF] RheingoldFASTA.dll                         113-1-------------- [6 func patched]
[05:50:26 INF] RheingoldFASTAConfigParsing.dll            ------------------- [skip]
[05:50:26 INF] RheingoldIDES.dll                          ------------------- [skip]
[05:50:27 INF] RheingoldInfoProvider.dll                  11311-------------- [7 func patched]
[05:50:27 INF] RheingoldInfoProvider.XmlSerializers.dll   ------------------- [skip]
[05:50:27 INF] RheingoldISPINext.dll                      113111------------- [8 func patched]
[05:50:27 INF] RheingoldISTACoreFramework.dll             11311-------------- [7 func patched]
[05:50:27 INF] RheingoldKMM.dll                           ------------------- [skip]
[05:50:27 INF] RheingoldMeasurement.dll                   11311-------------- [7 func patched]
[05:50:27 INF] RheingoldMeasurementCommon.dll             ------------------- [skip]
[05:50:27 INF] RheingoldMeasurementCommunication.dll      11311-------------- [7 func patched]
[05:50:27 INF] RheingoldOperationsReportConverter.dll     ------------------- [skip]
[05:50:28 INF] RheingoldPresentationFramework.dll         11311-------------- [7 func patched]
[05:50:28 INF] RheingoldProcessCommunicationBase.dll      ------------------- [skip]
[05:50:28 INF] RheingoldProgramming.dll                   11311-----1-------- [8 func patched]
[05:50:28 INF] RheingoldSessionController.dll             11311-------------- [7 func patched]
[05:50:28 INF] RheingoldSharpVectorSvgViewer.dll          ------------------- [skip]
[05:50:28 INF] RheingoldVehicleCommunication.dll          113-1-------------- [6 func patched]
[05:50:28 INF] RheingoldxVM.dll                           11311-------------- [7 func patched]
[05:50:28 INF] TestAutomationCore.dll                     ------------------- [skip]
[05:50:28 INF] WsiDataProvider.dll                        11311-------------- [7 func patched]
[05:50:28 INF]                                            ││││││││││││││││││└>[InteractionAdministrationModel]
[05:50:28 INF]                                            │││││││││││││││││└─>[ConfigurationService]
[05:50:28 INF]                                            ││││││││││││││││└──>[ServiceProgramCompilerLicense]
[05:50:28 INF]                                            │││││││││││││││└───>[PackageValidityService]
[05:50:28 INF]                                            ││││││││││││││└────>[IstaProcessStarter]
[05:50:28 INF]                                            │││││││││││││└─────>[IstaIcsServiceClient]
[05:50:28 INF]                                            ││││││││││││└──────>[VerifyAssemblyHelper]
[05:50:28 INF]                                            │││││││││││└───────>[IntegrityManager]
[05:50:28 INF]                                            ││││││││││└────────>[TherapyPlanCalculated]
[05:50:28 INF]                                            │││││││││└─────────>[ActivationCertificateHelper]
[05:50:28 INF]                                            ││││││││└──────────>[MainWindowViewModel]
[05:50:28 INF]                                            │││││││└───────────>[FscValidationClient]
[05:50:28 INF]                                            ││││││└────────────>[SecureAccessHelper]
[05:50:28 INF]                                            │││││└─────────────>[CommonServiceWrapper]
[05:50:28 INF]                                            ││││└──────────────>[LicenseAOSManager]
[05:50:28 INF]                                            │││└───────────────>[LicenseHelper]
[05:50:28 INF]                                            ││└────────────────>[LicenseManager]
[05:50:28 INF]                                            │└─────────────────>[LicenseWizardHelper]
[05:50:28 INF]                                            └──────────────────>[LicenseStatusChecker]
[05:50:28 INF] === ISTA Patch Done in 00:07 ===

[iggy2022]

hello rocdeng same problem on my side possible to contact me? thank you TC for your work

[tautcony]

Try this, the first run incorrectly skipped writing result during the backup process.

Restore all the programs, delete both @ista-patched & @ista-backup and try again.

But it shows [skip], and the backup process is later than this line of logs, there may be other issues.

[rocdeng]

Latest build has fixed the bug.