search

taviso / hotcorner

Tiny Hot Corners for Windows 10
GNU General Public License v3.0
380 stars 69 forks source link

Support for multimple monitors #12

Closed mrowqa closed 4 years ago

mrowqa commented 6 years ago

Hi,

thanks for the tool. I thought about writing such a thing myself, but eventually I landed here. Here is some contribution of mine that adds support for multiple monitors.

Regards, mrowqa

mrowqa commented 6 years ago

Solves #11.

Ortega-Dan commented 5 years ago

Hey @taviso , Looks like this contribution is nice. Please merge it into main. This project is great. And this pull request will make it better.

taviso commented 5 years ago

Thanks! Sorry for the slow response, the patch does indeed look good.

I'm just thinking about how to make it optional, i.e. if I only want it on one monitor. I like that there are no configuration files or registry keys, so I think maybe it should be an #ifdef. hmmm..

mrowqa commented 5 years ago

if I only want it on one monitor

Assuming it's just an example, does anyone actually want such a behavior? As far as I remember, on gnome shell the corners work on all screens.

You can also try changing MAX_MONITORS to 1 and see how it behaves. Hopefully, it iterates over monitors in the same order.

Ortega-Dan commented 5 years ago

if I only want it on one monitor

Assuming it's just an example, does anyone actually want such a behavior? As far as I remember, on gnome shell the corners work on all screens.

You can also try changing MAX_MONITORS to 1 and see how it behaves. Hopefully, it iterates over monitors in the same order.

Yeap, it works on all screens on Gnome 3.

gitguys commented 4 years ago

Is there a pre-compiled binary available for download that works on all connected monitors?

mrowqa commented 4 years ago

@gitguys I decided not to provide any binaries since building it is quick and simple and I adjusted the constants & hotkey locally for my personal usage.

Ortega-Dan commented 4 years ago

@gitguys I actually have a precompiled .exe that I deploy to my windows machines ... I've had it there for more than one year ... (as you can see from the last commits in there) You can check it out here .. withSuperEasyInstallInstructions

That was thanks to @mrowqa changes .. (his name is in my version of the README)