search

taw / magic-search-engine

Search engine for Magic cards
MIT License
47 stars 19 forks source link

Most of the needed changes for Unfinity draft boosters #166

Closed axxroytovu closed 1 year ago

axxroytovu commented 1 year ago

Unfinity boosters did not correctly separate attractions or include shocklands as valid pulls.

axxroytovu commented 1 year ago

This should resolve https://github.com/taw/magic-sealed-data/issues/25

Source: https://magic.wizards.com/en/news/feature/almost-everything-know-about-unfinity-boosters-2022-09-20

taw commented 1 year ago

I'm very happy to merge this and other pack yamls, but I'm still finishing the code, and it's easier for me to do this after it's all done. It shouldn't take longer than another week.

taw commented 1 year ago

I manually cherry picked patch_exclude_from_boosters.rb part as it doesn't conflict with anything.

taw commented 1 year ago

Manually merged contents of unf.yaml. Thanks.

axxroytovu commented 1 year ago

No problem. Just trying to find ways to help out while you work on the core code.

taw commented 1 year ago

The core code is done now, I might add some small improvements, but I don't expect to break anything.

If you want to do PR, it's probably best to not include index/*.json files as they'll probably conflict, and I can easily regenerate them anyway.