search

taw / magic-search-engine

Search engine for Magic cards
MIT License
47 stars 19 forks source link

Add "starter" and tournament decks #219

Closed axxroytovu closed 1 year ago

taw commented 1 year ago

I think this might crash right now due to duplicate card protection, especially 22 basics. I'll need to verify that it doesn't, or add a switch to turn it off for some sheets/decks.

axxroytovu commented 1 year ago

Having duplicate card protection only on for draft boosters seems appropriate. There is no duplicate protection for set/collector boosters either.

taw commented 1 year ago

I added duplicates: true flag that skips all duplicate protection and makes every pull completely independent of each other. Obviously it can't be combined with balanced. It should hopefully just work now.

taw commented 1 year ago

For what it's worth color balancing on a 32-element common sheet won't really do anything, all it does is guarantees at least 1 of each color, and then bumps probabilities of non-monocolored cards a bit so probabilities match.

With 32 commons, that's not really meaningful. But it's not going to cause any problems in practice.

axxroytovu commented 1 year ago

I'll keep that in mind for future products.