taw / magic-search-engine

Search engine for Magic cards
MIT License
45 stars 20 forks source link

Add jumpstart packs to sealed simulator #225

Closed axxroytovu closed 1 year ago

axxroytovu commented 1 year ago

On May 1, 2023, at 08:32, Tuấn Dương Đức [lokiplop908@gmail.com](mailto:lokiplop908@gmail.com) wrote: Please put the jumpstar in to pack simulator web , thank youu :3

I got this email and figured I'd put it here. Specifically they want to open jumpstart packs in https://mtg.wtf/sealed

axxroytovu commented 1 year ago

On May 1, 2023, at 8:51 AM, Tuấn Dương Đức lokiplop908@gmail.com wrote: Thank youu :3 , and you can put all the set secret liar into the sealed , is very okay to try it hehe

Also secret lair products I guess?

Owensleepy commented 1 year ago

Yes, that right

taw commented 1 year ago

So for Jumpstart, it sort of makes sense, but it really does not fit the current system.

I'm not sure which Secret Lair subsets would work, aren't they mostly predetermined?

taw commented 1 year ago

Here's a draft how it might look like:

name: "Jumpstart"
pack:
- infantry_1: 19
  white_rare_mythic: 1
- infantry_2: 19
  white_rare_mythic: 1
- powerstones_1: 19
  blue_rare_mythic: 1
- etc.
sheets:
  infantry_1:
    exact: true
    deck: "jmp/Infantry 1"
    count: 19
  white_rare_mythic:
    filter: "e:bro c:w"
    use: rare_mythic

Things are not set for this on so many levels, before we even get to the issue of foils.

This could be done, and we have all the required information for it already, but things just aren't setup for this.

Owensleepy commented 1 year ago

You can rest assured about the set seect lair that I have given, because everyone wants to open a pack in your pack simulator once in a lifetime. and I believe this system will perform beyond expectations. Actually, this set has more cards than that, it's over 1000 cards, it's very difficult to complete such a set, but I believe your web system can definitely do it.

Owensleepy commented 1 year ago

The set is working alright ?

On Tue, 2 May 2023, 08:16 Tomasz Wegrzanowski, @.***> wrote:

Here's a draft how it might look like:

name: "Jumpstart" pack:

  • infantry_1: 19 white_rare_mythic: 1
  • infantry_2: 19 white_rare_mythic: 1
  • powerstones_1: 19 blue_rare_mythic: 1
  • etc. sheets: infantry_1: exact: true deck: "jmp/Infantry 1" count: 19 white_rare_mythic: filter: "e:bro c:w" use: rare_mythic

Things are not set for this on so many levels, before we even get to the issue of foils.

— Reply to this email directly, view it on GitHub https://github.com/taw/magic-search-engine/issues/225#issuecomment-1530740870, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7REEYIGWAAK7JD737FN5ADXEBN7DANCNFSM6AAAAAAXSKCMFA . You are receiving this because you commented.Message ID: @.***>

Owensleepy commented 1 year ago

Hmm

axxroytovu commented 1 year ago

Jumpstart boosters should be fully implemented.

https://mtg.wtf/sealed?count%5B%5D=2&set%5B%5D=j22-jumpstart&count%5B%5D=0&set%5B%5D=mat&count%5B%5D=0&set%5B%5D=mat

axxroytovu commented 1 year ago

I forgot about the secret lair thing. @taw is this something that we want to implement? I don't know that it makes sense with what the Sealed tool is trying to do.

taw commented 1 year ago

Jumpstart works now.

Secret Lairs are not randomized, so there's no reason to put them here. If you want to see cards in various Secret Lairs, https://mtg.wtf/set/sld lists the subsets.

Owensleepy commented 1 year ago

So can we make a bundle box for any set ?

On Sun, 7 May 2023, 07:38 Tomasz Wegrzanowski, @.***> wrote:

Closed #225 https://github.com/taw/magic-search-engine/issues/225 as completed.

— Reply to this email directly, view it on GitHub https://github.com/taw/magic-search-engine/issues/225#event-9183415677, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7REEYJR5MP4LWQKFJ4XBVLXE3VJFANCNFSM6AAAAAAXSKCMFA . You are receiving this because you commented.Message ID: @.***>

axxroytovu commented 1 year ago

Yeah I don't see why not. The MOM bundle is just 8 set boosters.

Owensleepy commented 1 year ago

Yeah and a promo card too , is very okay to make a bundle box pack simulator for all set we need now.

On Wed, 10 May 2023, 23:55 Sam Zimmerman, @.***> wrote:

Yeah I don't see why not. The MOM bundle https://mtg.wtf/sealed?count%5B%5D=8&set%5B%5D=mom-set&count%5B%5D=0&set%5B%5D=mat&count%5B%5D=0&set%5B%5D=mat is just 8 set boosters.

— Reply to this email directly, view it on GitHub https://github.com/taw/magic-search-engine/issues/225#issuecomment-1542526083, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7REEYMEO5BAEB5L6JKYYXTXFPB75ANCNFSM6AAAAAAXSKCMFA . You are receiving this because you commented.Message ID: @.***>

Owensleepy commented 1 year ago

So i think we should have a secrect lair pack by random card or something funny in web simulator ?

On Thu, 11 May 2023, 00:21 Tuấn Dương Đức, @.***> wrote:

Yeah and a promo card too , is very okay to make a bundle box pack simulator for all set we need now.

On Wed, 10 May 2023, 23:55 Sam Zimmerman, @.***> wrote:

Yeah I don't see why not. The MOM bundle https://mtg.wtf/sealed?count%5B%5D=8&set%5B%5D=mom-set&count%5B%5D=0&set%5B%5D=mat&count%5B%5D=0&set%5B%5D=mat is just 8 set boosters.

— Reply to this email directly, view it on GitHub https://github.com/taw/magic-search-engine/issues/225#issuecomment-1542526083, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7REEYMEO5BAEB5L6JKYYXTXFPB75ANCNFSM6AAAAAAXSKCMFA . You are receiving this because you commented.Message ID: @.***>

axxroytovu commented 1 year ago

I don't think this makes much sense, since the goal is to simulate physical products as closely as possible. There is no physical way to buy a "random secret lair pack" so there is nothing to do.

Owensleepy commented 1 year ago

Yeah but The Secret Lair Drop Series are in English only. Each "drop" contains between three and seven cards , and is a possible to make a ppack series from any themes in web simulator , so can you try make again please ?

On Wed, 17 May 2023, 01:47 Sam Zimmerman, @.***> wrote:

I don't think this makes much sense, since the goal is to simulate physical products as closely as possible. There is no physical way to buy a "random secret lair pack" so there is nothing to do.

— Reply to this email directly, view it on GitHub https://github.com/taw/magic-search-engine/issues/225#issuecomment-1550187455, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7REEYOEKJ6FR6RVGHIBYNTXGPDVLANCNFSM6AAAAAAXSKCMFA . You are receiving this because you commented.Message ID: @.***>

Owensleepy commented 1 year ago

Mtg lord of the ring collector set pack is already update to pack simulator ?

Vào 10:38, Th 4, 17 thg 5, 2023 Tuấn Dương Đức @.***> đã viết:

Yeah but The Secret Lair Drop Series are in English only. Each "drop" contains between three and seven cards , and is a possible to make a ppack series from any themes in web simulator , so can you try make again please ?

On Wed, 17 May 2023, 01:47 Sam Zimmerman, @.***> wrote:

I don't think this makes much sense, since the goal is to simulate physical products as closely as possible. There is no physical way to buy a "random secret lair pack" so there is nothing to do.

— Reply to this email directly, view it on GitHub https://github.com/taw/magic-search-engine/issues/225#issuecomment-1550187455, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7REEYOEKJ6FR6RVGHIBYNTXGPDVLANCNFSM6AAAAAAXSKCMFA . You are receiving this because you commented.Message ID: @.***>

taw commented 1 year ago

We don't add any packs until set is fully spoiled, and it's not fully spoiled on mtgjson yet.

Owensleepy commented 1 year ago

Ok, thanks for the clarification.

Vào 1:43, CN, 11 thg 6, 2023 Tomasz Wegrzanowski @.***> đã viết:

We don't add any packs until set is fully spoiled, and it's not fully spoiled on mtgjson yet.

— Reply to this email directly, view it on GitHub https://github.com/taw/magic-search-engine/issues/225#issuecomment-1585767238, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7REEYI6APZOBTQJMA2HBV3XKS56XANCNFSM6AAAAAAXSKCMFA . You are receiving this because you commented.Message ID: @.***>