taw / magic-search-engine

Search engine for Magic cards
MIT License
45 stars 20 forks source link

March of the Machine: Aftermath boosters #226

Closed axxroytovu closed 1 year ago

axxroytovu commented 1 year ago

Leaving this as draft until MAT cards are put into the json. Right now everything crashes when trying to compile.

taw commented 1 year ago

MAT data in mtgjson is incomplete and has some bugs, but it looks like it's good enough to add.

taw commented 1 year ago

MAT imported, but some important things are broken including card numbers which cannot decide if they're 37 or 0037.

Are the boosters working now? If not, we can try again after mtgjson update or two.

axxroytovu commented 1 year ago

Ok, yeah it looks like things at least don't crash. They're VERY wrong, especially the collector booster, but they don't instantly break.

taw commented 1 year ago

common's foil sheet will not work for a set without commons, as it thinks there's nonzero chance of common foil, so this crashes.

Fortunately WotC tells us the rates here: "Traditional foil card of any rarity. For approximately 1 in 6 boosters, this is a rare or mythic rare."

taw commented 1 year ago

I disabled mat-collector for now, but mat looks good enough with foils fixed.

taw commented 1 year ago

mat-collector enabled https://mtg.wtf/pack/mat-collector @axxroytovu Does it look right to you?

axxroytovu commented 1 year ago

I messed up line 35, which should be filter: "e:{set} frame:extendedart"

otherwise looks good