search

taw / magic-search-engine

Search engine for Magic cards
MIT License
45 stars 20 forks source link

Color balance with booster type any #227

Closed axxroytovu closed 1 year ago

axxroytovu commented 1 year ago

My attempt to resolve https://github.com/taw/magic-search-engine/issues/207

Everything should be working. I don't know how to modify search-engine/lib/color_balanced_card_sheet.rb to properly catch errors but I manually checked that the math does work.

taw commented 1 year ago

Yeah, I wanted to do something like that. I'll need to verify math and run generation.

You can do search-engine/bin/open_packs 1000xcode to do empirical results as well.

taw commented 1 year ago

Merging this resulted in some weird changes to dmu, mom, and neo-set:

wat.diff.txt

I'm guessing there's some code bug in the math.

axxroytovu commented 1 year ago

So it does look like these were because of the new balance code, but it's because balanced/any doesn't like being used as a subsheet. I'll go through and correct those tonight when I'm not on my phone.

axxroytovu commented 1 year ago

Fixed here https://github.com/taw/magic-search-engine/pull/228

taw commented 1 year ago

It should all be working now