Closed taw closed 1 year ago
This is now working except for that random slot and some UI cleanup.
Random slots implemented as well.
It needs minor cleanup:
@axxroytovu I changed labels a bit. Is this clear enough https://mtg.wtf/pack/mom-jumpstart ?
I like it, much clearer. Im also working on a way for the automated builder to use the deck name instead of precon-x
and that should dramatically improve readability.
Yeah, it would probably be better to just strip all special characters and call it go_to_school_1
, angels_1
, buff_1_foil
etc.
The whole precon_x was really meant as a placeholder, I didn't have time to go back and fix it.
Also it's really unrelated but I see that there's extra dash at the end of slug for deck names that end with special character like: https://mtg.wtf/deck/jmp/above-the-clouds-1-
This final dash should be stripped as well. After that small fix, deck.slug.tr("-", "_")
will work as sheet name.
I was able to .chomp("-")
to strip the trailing dash easily enough.
Fix is here: https://github.com/taw/magic-search-engine/pull/232
Everything is done here.
There's 6 sets with Jumpstart. Here's automatically generated yaml (I'd put more quotes everywhere, but that's what
yaml
library is doing) for two of them, bybin/generate_jumpstart_precon_boosters
:I think it would be fairly straightforward to get it connected all the way. It would need new card sheet type
fixed
, which might even have some limited uses elsewhere, like this:But other than this one use in
2xm-vip
, I'm not sure any other booster really needs it.