search

taw / magic-search-engine

Search engine for Magic cards
MIT License
45 stars 20 forks source link

Add tokens to decks #239

Open axxroytovu opened 1 year ago

axxroytovu commented 1 year ago

Some secret lair drops are almost entirely tokens, like Bitterblossom Dreams. We don't need to go back and add all of the tokens to every deck, but having a framework to allow tokens would be useful.

taw commented 1 year ago

Do you want to mark them as [token] for sake of data entry, and for now we'll just ignore any lines with [token], but when they're supported it will all Just Work?

axxroytovu commented 1 year ago

I can do that 👍

taw commented 1 year ago

I manually picked one of the decks from your PR and implemented [token] annotation. It gets to deck indexer, and then it gets ignored as db doesn't have tokens.

axxroytovu commented 11 months ago

I started looking at the Hero's Path challenge deck products, which are entirely made of tokens. Do we want to support these or is this too much to change for no benefit?

https://mtg.fandom.com/wiki/Face_the_Hydra

https://scryfall.com/sets/tfth?as=grid&order=set

taw commented 11 months ago

Adding tokens is on a someday/maybe list, just like adding Alchemy was, so it could happen someday, but no real plans right now.

If you want you can add the data now, and it will just not be processed for now.