search

taw / magic-search-engine

Search engine for Magic cards
MIT License
47 stars 19 forks source link

Updates June 14 #251

Closed axxroytovu closed 1 year ago

axxroytovu commented 1 year ago

LTR complete Some prerelease boosters

taw commented 1 year ago

ltr-collector crashes so I had to disable it.

I'll try to reenable once mtgjson has full spoiler.

axxroytovu commented 1 year ago

Strange. I checked it against the current build and it was compiling correctly. Do you have the error message?

taw commented 1 year ago

If I enable it and rebuild the index, I then get:

$  ./bin/human_export_sealed_data tmp/sealed
/Users/taw/github/magic-search-engine/search-engine/lib/pack_factory.rb:8:in `raise_sheet_error': Error building ltr/extended_core_rare_mythic: No subsheets present (RuntimeError)
    from /Users/taw/github/magic-search-engine/search-engine/lib/pack_factory.rb:15:in `build_sheet_from_subsheets'
    from /Users/taw/github/magic-search-engine/search-engine/lib/pack_factory.rb:78:in `build_sheet'
    from /Users/taw/github/magic-search-engine/search-engine/lib/pack_factory.rb:97:in `build_top_level_sheet'
    from /Users/taw/github/magic-search-engine/search-engine/lib/pack_factory.rb:122:in `block in for'
    from /Users/taw/github/magic-search-engine/search-engine/lib/pack_factory.rb:121:in `each'
    from /Users/taw/github/magic-search-engine/search-engine/lib/pack_factory.rb:121:in `map'
    from /Users/taw/github/magic-search-engine/search-engine/lib/pack_factory.rb:121:in `for'
    from /Users/taw/github/magic-search-engine/search-engine/lib/card_database.rb:127:in `block in supported_booster_types'
    from /Users/taw/github/magic-search-engine/search-engine/lib/card_database.rb:125:in `each_key'
    from /Users/taw/github/magic-search-engine/search-engine/lib/card_database.rb:125:in `supported_booster_types'
    from ./bin/human_export_sealed_data:81:in `call'
    from ./bin/human_export_sealed_data:93:in `<main>'
axxroytovu commented 1 year ago

Ok. It looks like https://mtg.wtf/card?q=e%3Altr+frame%3Aextendedart+-is%3Afoilonly is returning nothing, but https://scryfall.com/search?q=e%3Altr+frame%3Aextendedart is showing the correct cards. Once that data flows down into MTGJson (hopefully in today's build) then we should be good.

I can't search for foilonly on scryfall, but the surge foil versions are in the 700s so they're easy to spot.

taw commented 1 year ago

Reenabled https://mtg.wtf/pack/ltr-collector Everything builds now