taw / magic-search-engine

Search engine for Magic cards
MIT License
45 stars 20 forks source link

Fix format legality differences (mostly Alchemy and Historic) #259

Open taw opened 12 months ago

taw commented 12 months ago

Now that Alchemy is implemented, we have no reason to have any differences from mtgjson.

At the start of this issue there are 678 differences (down to 12), mostly Alchemy/Historic, but there's a few others.

Most are bugs in Alchemy/Historic.

I now added restricted legality for Alchemy/Historic for conjured/specialized cards that can't go into deck construction, but can appear in games. I'm not counting this in report below.

Raw report (./bin/report_legality_differences):

Format alchemy - 2 / 3410 differences
* Rise from the Grave - mtgjson:not it format - db:legal
* Shorecomber Crab - mtgjson:not it format - db:legal

Format duel - 3 / 25879 differences
* Cleanse - mtgjson:legal - db:banned
* Invoke Prejudice - mtgjson:legal - db:banned
* Stone-Throwing Devils - mtgjson:legal - db:banned

Format historic - 5 / 9358 differences
* Assault Strobe - mtgjson:not it format - db:legal
* Divide by Zero - mtgjson:not it format - db:legal
* Fog - mtgjson:not it format - db:legal
* Force Spike - mtgjson:not it format - db:legal
* Ponder - mtgjson:not it format - db:legal

Format penny - 2 / 16519 differences
* Chittering Host - mtgjson:not it format - db:legal
* Hanweir, the Writhing Township - mtgjson:not it format - db:legal

The following are mtgjson bugs: