taw / magic-search-engine

Search engine for Magic cards
MIT License
47 stars 19 forks source link

Remaining LCC / LCI issues #277

Closed taw closed 8 months ago

taw commented 11 months ago

Missing artist information:

No artist for Cavern of Souls ltc 392z
No artist for Bridge from Below spg 3
No artist for Kalamax, the Stormsire spg 13

Ambiguous cards:

bin/resolve_card "lcc" "Ahoy Mateys" "The Indomitable" "[LCC:43]"
bin/resolve_card "lcc" "Ahoy Mateys" "The Indomitable" "[LCC:75]"
bin/resolve_card "lcc" "Ahoy Mateys" "Storm Fleet Negotiator" "[LCC:46]"
bin/resolve_card "lcc" "Ahoy Mateys" "Storm Fleet Negotiator" "[LCC:78]"
bin/resolve_card "lcc" "Ahoy Mateys" "Francisco, Fowl Marauder" "[LCC:49]"
bin/resolve_card "lcc" "Ahoy Mateys" "Francisco, Fowl Marauder" "[LCC:81]"
bin/resolve_card "lcc" "Ahoy Mateys" "The Grim Captain's Locker" "[LCC:50]"
bin/resolve_card "lcc" "Ahoy Mateys" "The Grim Captain's Locker" "[LCC:82]"
bin/resolve_card "lcc" "Ahoy Mateys" "Skeleton Crew" "[LCC:53]"
bin/resolve_card "lcc" "Ahoy Mateys" "Skeleton Crew" "[LCC:85]"
bin/resolve_card "lcc" "Ahoy Mateys" "Broadside Bombardiers" "[LCC:54]"
bin/resolve_card "lcc" "Ahoy Mateys" "Broadside Bombardiers" "[LCC:86]"
bin/resolve_card "lcc" "Ahoy Mateys" "Gemcutter Buccaneer" "[LCC:55]"
bin/resolve_card "lcc" "Ahoy Mateys" "Gemcutter Buccaneer" "[LCC:87]"
bin/resolve_card "lcc" "Ahoy Mateys" "Arm-Mounted Anchor" "[LCC:67]"
bin/resolve_card "lcc" "Ahoy Mateys" "Arm-Mounted Anchor" "[LCC:99]"
axxroytovu commented 11 months ago

https://github.com/taw/magic-search-engine/pull/279 resolved missing booster packs with two more actions:

magreenblatt commented 9 months ago

I'm having some difficulty finding the source of information for the LCI Set booster showcase/boosterfun drop rates that you've stated here. Can you provide any additional links or details?

From what I've been able to find so far, we lack sufficient information to accurately model the contents of the following LCI Set booster slots (see details below):

From https://magic.wizards.com/en/news/feature/collecting-the-lost-caverns-of-ixalan, we know the following about LCI Set boosters:

From https://magic.wizards.com/en/news/making-magic/set-boosters-2020-07-25, we might reasonably assume that the following still applies for LCI Set boosters:

Thanks in advance :)

axxroytovu commented 9 months ago

There's a lot of questions there but I'll do my best to hit all of them. Most of the rates I use are assumptions based on previous sets and then validated using a chi-square test on box opening videos to make sure they're still valid.

Some of the key assumptions for LCI:

I still don't have good data for the special guest drop rates so that's a complete guess.

axxroytovu commented 9 months ago

As for the wildcard slots, the distribution of common/uncommn/rare/mythic does match up to that listed rate.

taw commented 8 months ago

Are we done with LCC / LCI?

axxroytovu commented 8 months ago

I think so. The latest data I have is that our assumptions about the SPG rate is very close to accurate.

taw commented 8 months ago

OK, closing the issue then.