taw / magic-search-engine

Search engine for Magic cards
MIT License
43 stars 20 forks source link

CLB: Filter out foil EA cards #299

Closed kodawah closed 4 months ago

kodawah commented 6 months ago

I've gotten a report that we include too many cards in the collector booster for CLB

https://docs.google.com/spreadsheets/d/1vXSBHt0cJAFhkU404hfOlXTSANaLT1Z3Becjixf6aXs/edit#gid=1240952972

the cards in yellow appear in the sample boosters not the collector boosters, and the wotc article confirms that

1 Non-foil extended-art rare or mythic rare from the Commander Legends: Battle for Baldur's Gate set 1 Non-foil extended-art rare or mythic rare from Commander Legends: Battle for Baldur's Gate Commander set

however

  1. https://mtg.wtf/card?q=e%3Aclb+number%3A553-606+-is%3Afoil returns an empty set
  2. i don't know where the non-ea mythic foils (like Durnan of the Yawning Portal) come from

@taw can you advise? cc @axxroytovu

the-muppet commented 6 months ago

they come from the commander decks

taw commented 5 months ago

@kodawah @axxroytovu Does anything need to be done about this issue?

kodawah commented 5 months ago

@taw the second query should return some cards, but it's empty

taw commented 5 months ago

Is this an issue with mtgjson foiling data? Foil data comes from mtgjson directly (other than small number of bugfixes in indexer). So it's probably best to report this upstream.

the-muppet commented 5 months ago

assuming we're talking about the same cards - using Durnan as the example still; they are correct within mtgjson

axxroytovu commented 5 months ago

e:clb number:553-606 already doesn't include any of the cards you highlighted so you should be able to just leave that query alone.

I dislike e:clb number:607-645 -is:foil from a reliability standpoint, since relying on the foiling for cards that may or may not have different foiling is risky. I'd prefer e:clb number:607-645 -alt:(e:clb number:646-657), since it excludes the same cards and is both clearer and less prone to future database changes.

kodawah commented 5 months ago

I dislike e:clb number:607-645 -is:foil from a reliability standpoint, since relying on the foiling for cards that may or may not have different foiling is risky. I'd prefer e:clb number:607-645 -alt:(e:clb number:646-657), since it excludes the same cards and is both clearer and less prone to future database changes.

that wouldn't match what the card distribution model describes afaict

axxroytovu commented 5 months ago

https://mtg.wtf/card?q=e%3Aclb+number%3A607-645+-alt%3A%28e%3Aclb+number%3A646-657%29+%2B%2B

Can you explain your comment further? Checking the above it does correctly reduce the card count from 40 to 28, excluding the specific 12 cards you highlighted in the spreadsheet.

axxroytovu commented 5 months ago

Also e:clb number:607-645 -is:foil incorrectly removes Harper Recruiter and Stand Alone, which do correctly appear in collector boosters.

kodawah commented 5 months ago

Can you explain your comment further? Checking the above it does correctly reduce the card count from 40 to 28, excluding the specific 12 cards you highlighted in the spreadsheet.

yeah that part is fine (thanks for improving my query), but there are two separate slots

this is the problematic part: https://mtg.wtf/card?q=e%3Aclb+number%3A553-606+-is%3Afoil it should return these results: https://www.mtgban.com/search?q=s%3Aclb+cn%3E553+cn%3C606+-f%3Afoil

axxroytovu commented 5 months ago

I think your mtgban query is wrong, since those cards definitely exist in foil. https://www.tcgplayer.com/product/273435?Printing=Foil&page=1&irclickid=UfPwmNT-8xyPWCty-6Ww21zPUkHz9:3JLwaVQA0&sharedid=&irpid=4931599&irgwc=1&utm_source=impact&utm_medium=affiliate&utm_campaign=Scryfall&Language=English

kodawah commented 5 months ago

I think your mtgban query is wrong, since those cards definitely exist in foil. https://www.tcgplayer.com/product/273435?Printing=Foil&page=1&irclickid=UfPwmNT-8xyPWCty-6Ww21zPUkHz9:3JLwaVQA0&sharedid=&irpid=4931599&irgwc=1&utm_source=impact&utm_medium=affiliate&utm_campaign=Scryfall&Language=English

they exist in foil, they are just not found in CBB, but rather in sample packs

the-muppet commented 5 months ago

Archivist is in collector boosters fwiw. just the commanders/ subcommanders in EAF were sampler pack exclusive

kodawah commented 5 months ago

they exist in foil, they are just no found in CBB, but rather in sample packs Archivist is in collector boosters fwiw

for clarity:

hope it's clear now

axxroytovu commented 5 months ago

Ok, so:

the-muppet commented 5 months ago

they exist in foil, they are just no found in CBB, but rather in sample packs Archivist is in collector boosters fwiw

for clarity:

  • the NON FOIL VERSION appears in CBB only
  • the FOIL VERSION appears in Sample Packs
  • BOTH VERSIONS exist
  • mtg.wtf search query returns empty when the NON FOIL version is selected
  • the empty query prevents the correct version from being added to the cbb sheet

hope it's clear now

Hi. Me again... Your first bullet is incorrect.

kodawah commented 5 months ago

they exist in foil, they are just no found in CBB, but rather in sample packs Archivist is in collector boosters fwiw

for clarity:

  • the NON FOIL VERSION appears in CBB only
  • the FOIL VERSION appears in Sample Packs
  • BOTH VERSIONS exist
  • mtg.wtf search query returns empty when the NON FOIL version is selected
  • the empty query prevents the correct version from being added to the cbb sheet

hope it's clear now

Hi. Me again... Your first bullet is incorrect.

wait what? is the article linked wrong then?

1 Non-foil extended-art rare or mythic rare from the Commander Legends: Battle for Baldur's Gate set
1 Non-foil extended-art rare or mythic rare from Commander Legends: Battle for Baldur's Gate Commander set

@axxroytovu I think I'm lost, any chance you could take over the patch?

the-muppet commented 5 months ago

I dont know anything about any articles... But If it says that non foil EA archivist is only found in collector booster boxes.. then yes, the article is wrong.

not trying to be a buzzkill :/

Source: Myself. Having opened somewhere north of a thousand of them

kodawah commented 5 months ago

this is the article im referencing btw https://magic.wizards.com/en/news/feature/collecting-commander-legends-battle-for-baldurs-gate

the-muppet commented 5 months ago

I redact all statements and claims made on this thread and bid you all adieu.

kodawah commented 5 months ago

updated