MB1: Rename draft booster to retail booster

taw / magic-search-engine

Search engine for Magic cards

MIT License

43 stars 20 forks source link

MB1: Rename draft booster to retail booster #314

Closed kodawah closed 2 months ago

kodawah commented 2 months ago

cc @axxroytovu

axxroytovu commented 2 months ago

Why though? The retail tag doesn't add anything and it removes the information that it's a draftable booster.

kodawah commented 2 months ago

"retail" is the name of the booster expected in mtg-sealed-content, but every one of mb1 is draftable, it would align with other boosters are tagged (convention-2021 and convention)

taw commented 2 months ago

I think "-draft" for the most common kind of draft booster for the set is fine. Convention boosters were just some special extra things, right?

Also right now I have some aliasing logic, where X-draft / X-play / X-mtgo can be aliased as just X (example). That's quite convenient if you don't remember which sets had which kind as default. This rename would need updating that logic for mb1. Now this quite hacky, but it's nice to have.

kodawah commented 2 months ago

im fine renaming the booster type on the other repo, whichever works

axxroytovu commented 2 months ago

Fixed in https://github.com/mtgjson/mtg-sealed-content/pull/163