taw / magic-search-engine

Search engine for Magic cards
MIT License
47 stars 19 forks source link

Mh3 #317

Closed axxroytovu closed 3 months ago

ZeldaZach commented 3 months ago

LGTM

taw commented 3 months ago
Expected query is:front is:nonfoil (e:m3c r:r (frame:extendedart or number<152 deck:'eldrazi incursion')) to return 52, got 39
Expected query is:front is:foil (e:mh3 number:381-383 number:/z/) to return 3, got 1
Expected query is:front is:nonfoil (e:mh3 (number:320-446a) r:m -is:reprint alt:((alt:(e:mh3 number:320-361 or e:mh3 number:381-383 or e:mh3 number:442-446a) alt:(e:mh3 number:362-380)) or (alt:(e:mh3 number:320-361 or e:mh3 number:381-383 or e:mh3 number:442-446a) alt:(e:mh3 number:384-441)) or (alt:(e:mh3 number:362-380) alt:(e:mh3 number:384-441))) -is:foilonly) to return 12, got 13
Expected query is:front is:nonfoil (e:mh3 (number:320-446a) r:m -is:reprint alt:((alt:(e:mh3 number:320-361 or e:mh3 number:381-383 or e:mh3 number:442-446a) alt:(e:mh3 number:362-380)) or (alt:(e:mh3 number:320-361 or e:mh3 number:381-383 or e:mh3 number:442-446a) alt:(e:mh3 number:384-441)) or (alt:(e:mh3 number:362-380) alt:(e:mh3 number:384-441))) -is:foilonly) to return 12, got 13
axxroytovu commented 3 months ago

The 1, 13, and 13 are annoyingly expected until scryfall fixes the serialized concept Eldrazi.

I'll dig into why the other one is broken

axxroytovu commented 3 months ago

Oh right, it doesn't like single quotes and I need to use escaped double quotes instead.