search

tazz4843 / whisper-rs

Rust bindings to https://github.com/ggerganov/whisper.cpp
The Unlicense
659 stars 108 forks source link

Update whisper.cpp version to 1.5.4 #109

Closed Andreybest closed 8 months ago

Andreybest commented 8 months ago

Title says it all.

Changed version of whisper-rs-sys to 0.8.1

Works for me in simple environment as before.

Fixes #103

tazz4843 commented 8 months ago

Looks like whisper.cpp added a new function in these updates, this should be added: see https://github.com/ggerganov/whisper.cpp/compare/d38af151a1ed5378c5a9ae368e767ed22c8ab141...0b9af32a8b3fa7e2ae5f15a9a08f5b10394993f5#diff-46bc59b448d0e369ff4fbbc995a5c509db6caf1cee3a458f17482fae3086e457R318-R319

Andreybest commented 8 months ago

Looks like whisper.cpp added a new function in these updates, this should be added: see ggerganov/whisper.cpp@d38af15...0b9af32#diff-46bc59b448d0e369ff4fbbc995a5c509db6caf1cee3a458f17482fae3086e457R318-R319

My bad, haven't checked .h file changes. Added this function + bumped version of whisper-rs to 0.10.1 And I supposed that the bindings.rs file is being generated into src/ folder, but it's not. So I've copied it from build folder. Not sure if it's correct approach, sorry - first time working with bindings.

tazz4843 commented 8 months ago

If possible, can you run bindgen on a Linux system to minimize the change here? If not, no worries, just remove the bindings and I'll do so myself after merge.

Andreybest commented 8 months ago

If possible, can you run bindgen on a Linux system to minimize the change here? If not, no worries, just remove the bindings and I'll do so myself after merge.

Done. Thx.

tazz4843 commented 8 months ago

Thanks :)