search

tazz4843 / whisper-rs

Rust bindings to https://github.com/ggerganov/whisper.cpp
The Unlicense
607 stars 105 forks source link

Metal fails on 10.x, works on master #128

Closed carlosdp closed 2 months ago

carlosdp commented 2 months ago

I saw a note that you were holding off until there were more patches before publishing 0.11, but I would recommend either publishing it anyways, or at least publish a fix version of 0.10 with the currently pinned version of whisper.cpp in order to fix Metal usage.

The 0.10.X version currently on crates.io has an older version of whisper.cpp that crashes on metal inference, this was fixed in December, but has not reached this crate yet, which lost me a few hours of work until I figured out what was going on 😅

Either way, hopefully others having this issue will see this and save some time: pin to the git project instead of the crates.io version and it'll work (you'll need to get the ggml-metal.metal from the pinned whisper.cpp commit and put it in your working directory to get it to work, though. Ideally this would be fixed, maybe I'll look at that some day)

The fix commit on whisper.cpp repo for reference: https://github.com/ggerganov/whisper.cpp/pull/1633

tazz4843 commented 2 months ago

0.11 published, pinning this issue nonetheless.