search

tazz4843 / whisper-rs

Rust bindings to https://github.com/ggerganov/whisper.cpp
The Unlicense
607 stars 105 forks source link

Update whisper.cpp version to 1.6.2 #142

Closed arizhih closed 1 month ago

tazz4843 commented 1 month ago

See review comments

arizhih commented 1 month ago

I've added wrapper, but really I don't know how to wrap whisper_rs_sys::whisper_aheads correctly because it contains pointers.

arizhih commented 1 month ago

I think now it safe and it's not possible to use it incorrectly. All raw int values are checked inside whisper.cpp on state creation step and error is returned if values are incorrect.

arizhih commented 1 month ago

@tazz4843 Hi, whisper.cpp released new minor version, nothing changed in API. I've decided to update my PR to the latest release.

thewh1teagle commented 1 month ago

@arizhih Tested on macOS. works great.