tazz4843 / whisper-rs

Rust bindings to https://github.com/ggerganov/whisper.cpp
The Unlicense
607 stars 105 forks source link

Add a rustified progress callback. #77

Closed marmistrz closed 10 months ago

marmistrz commented 10 months ago

This is a proof-of-concept. I will extend the docs once I get maintainer feedback.

Known issues

marmistrz commented 10 months ago

Given that the 170% progress issue also occurs on master, could we have this merged without the issue resolved?

tazz4843 commented 10 months ago

I was unaware it did so. In that case merging it would be fine, if there's nothing more you want to add here.

marmistrz commented 10 months ago

I'll just update the docs beforehand.

marmistrz commented 10 months ago

This should be ready for merging. Btw. please make sure that you build the full example in CI, looks like the previous commit was actually broken ^^

tazz4843 commented 10 months ago

Btw. please make sure that you build the full example in CI, looks like the previous commit was actually broken ^^

Never crossed my mind to add example testing in CI, I'll give that a shot. Thanks for the PR!