tazz4843 / whisper-rs

Rust bindings to https://github.com/ggerganov/whisper.cpp
The Unlicense
607 stars 105 forks source link

whisper-rs-sys is likely compiled without AVX support #78

Closed marmistrz closed 8 months ago

marmistrz commented 10 months ago

The fix is proposed here: https://github.com/ggerganov/whisper.cpp/pull/1174

tazz4843 commented 10 months ago

Given how long it's been since an upstream release I'm probably just going to end up picking the latest git master and making a new release.

marmistrz commented 10 months ago

Strangely enough, I looked more closely into this, and even though whisper.cpp itself was compiled without AVX, I can't reproduce it with whisper-rs. Would it make some sense to add AVX detection into the tests (with an informative error message that "if your hardware doesn't support AVX, disable the test"?)

tazz4843 commented 10 months ago

whisper-rs currently doesn't have any tests for much functionality since bundling a model with every test is somewhat painful for what's just a thin wrapper. If you wanted to add some though, by all means feel free to do so.

tazz4843 commented 10 months ago

See #85