search

tcsaba101 / SG21

Adding sensor code to OS217
GNU General Public License v3.0
0 stars 0 forks source link

NVM storage addresses. #4

Open pbecchi opened 7 years ago

pbecchi commented 7 years ago

I have seen you have done extensive modifications to NMV addresses , this may conflict with my previous one. This relocations are necessary because ROM Memory is very small on Arduinos and ESp8266. But with ESP32 there is a new large NVM memory available that can be addressed easily .
I strongly suggest we use that NVM memory for all your parameters , CODING WILL BE MUCH SIMPLER !

tcsaba101 commented 7 years ago

The details in Cloud_testing/Documents/Tables....xls file https://github.com/tcsaba101/SG21/blob/Cloud_testing/Documents/Tables_SG_20_v06.xlsx

Is it ok. for you, or should I change something?

I couldnt solve the freeflow problem, what causing the noise on the flow meter cable. I am reluctant to make opto-coupler input, or 4.20mA input, what should work definitely, because I don't want to expose 5V on the cable. Otherwise I should make a separate supply from 24VAC. Right now I try to filter in the software the noise. And/Or decrease the input resistance.

I will be out of the office from tomorrow till Sunday (University). Then form Oct 5-10 (Elba).

I would commit the last minors this evening and then next commit after Elba, if it is ok. Of course we can communicate issues while I am out.

pbecchi commented 7 years ago

Ok I will study the best way to store in Esp32 NVM all your data without any change to EEprom storage used in standard OpenSprinkler firmware. I will start working on Options&Sensors while you are away , but I am not sure that all your code will be integrated when you are back. Please check with me status of my work before adding new commits. It will be good if I can keep in touch while you are away, for this work and for SmartSolenoid.... I can reach you by mail? Paolo

tcsaba101 commented 7 years ago

Today I commit some minor things, mainly comments, and I will not commit till 10th Oct. Meanwhile we can find out the next steps. You can reach by mail, but I will read and answer infrequent.

tcsaba101 commented 7 years ago

I have brushed the code committing to Cloud_testing branch. The fine brushing are haven't committed to Options branch. I think you should launch from the Cloud_testing branch. The Cloud related parts are two solid code sections in main.cpp: https://github.com/tcsaba101/SG21/blob/c1c782571a16923779cdaba94b51b870d759052e/main.cpp#L479-L518 https://github.com/tcsaba101/SG21/blob/c1c782571a16923779cdaba94b51b870d759052e/main.cpp#L1385-L2031

If you cut them out, it compiles error free.