search

tdwg / cd

Collection Descriptions
Creative Commons Attribution 4.0 International
23 stars 10 forks source link

Updates to JSON schema files #427

Closed jbstatgen closed 1 year ago

jbstatgen commented 1 year ago

This is the issue to note and assemble suggestions for updates to the JSON schema files.

jbstatgen commented 1 year ago

RecordLevel schema file:

lines 34-37:

   "collectionDescriptionScheme":
    {
        "$ref": "https://raw.githubusercontent.com/tdwg/cd/master/standard/json-schema/collection-description-scheme.json"
    },

Proposal:

    "hasCollectionDescriptionScheme":   
    {
        "description": "A grouping of multiple ObjectGroups for a particular use case, purpose or implementation." ,
        "type": "array",
        "items": 
        {
            "$ref": "https://raw.githubusercontent.com/tdwg/cd/master/standard/json-schema/collection-description-scheme.json"
        },
        "minItems": 1,
        "uniqueItems": true
    },
essvee commented 1 year ago

Fixed in this commit, thanks for flagging @jbstatgen!

jbstatgen commented 1 year ago

@essvee another potential catch:

In ltc:ObjectGroup, we added alternativeCollectionName, however, I don't think it should be required. Though currently it is, or at least it is in the JSON file in the review branch.

Can you please have a look and update and/or let me know?

Thanks!

essvee commented 1 year ago

Made a separate issue (#452) for the required/repeatable issue flagged, so closing this one.