search

team-folivora / annoto

Medical annotation tool
MIT License
0 stars 1 forks source link

Add basic CI #3

Closed bewee closed 2 years ago

bewee commented 2 years ago

This PR adds a first basic CI pipeline

bewee commented 2 years ago

I suggest splitting up #4 to move release-related workflows to a separate PR, what do you think? Also, we considered hosting the app on e.g. heroku and automatically deploying the main branch there

jb3rndt commented 2 years ago

Yeah I agree. But I'm not sure if we should split up testing, linting, converage, formatting (is already separate) and building (upload to heroku and so on) into separate workflows to have a more isolated environment for all of them and to directly see what failed? Will become many pipelines though...

bewee commented 2 years ago

From my experience, build, lint and test are usually put into one workflow together. But I would be fine with separate workflows as well. However, I am also not sure whether this would make it easier for us with this then huge number of pipelines. We need to also keep in mind that each pipeline needs to be set up separately, something that is only required once if we use a combined workflow.

I have put formatting in separate workflows since they use custom gh actions and thus do not require the complete node/python environment setup.

I completely agree with creating a separate workflow for release. I don't completely know yet how this one should look like. I suspect something like building a release and deploying on heroku as soon as a tag is pushed?

jb3rndt commented 2 years ago

Ok lets try it how it is now. For release we have to see what opportunities heroku gives us. Afaik one can connect the github repo to heroku and it is automatically updated on heroku when pushed to a specified branch but im not sure. Building a release would be independent of that then.

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@2cffc74). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff            @@
##             main        #3   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         2           
  Lines           ?         6           
  Branches        ?         0           
========================================
  Hits            ?         6           
  Misses          ?         0           
  Partials        ?         0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2cffc74...4ee5430. Read the comment docs.