search

team-perfect-deliverables / charlie

A distributed, actor-based Blackjack system for research and teaching
1 stars 0 forks source link

Adviser #3

Closed JacobLeach closed 10 years ago

JacobLeach commented 10 years ago

Needs more testing and perhaps some corrections for three card ace hands

JacobLeach commented 10 years ago

Google led me to fuzz testing. i'm going to try and make it so i can automatically throw it all sorts of inputs and check for an exception

JacobLeach commented 10 years ago

Added a Fuzz Unit Test. Running it 10M times now.

JacobLeach commented 10 years ago

Passed 10M, running 1B.

JacobLeach commented 10 years ago

I'm assuming I shouldn't have to check for the hand being bust or blackjack right? I should assume that the hands passed are correct?

JacobLeach commented 10 years ago

Ok the 1B didn't finished (after hours lol) but I've got to assume it hit all the possible hands.

travisby commented 10 years ago

Cursory reading looks really good. I'll run the tests and try to come up with edge cases tomorrow night, and then accept the PR. Added a few comments to some of the lines if you could take a look at them.

travisby commented 10 years ago

does any more of this code depend on SPLIT never being used? We must go back and reimplement split.

JacobLeach commented 10 years ago

Yea. I have to redo it since there are now hand combinations that I do not account for. Before I just treated hands with aces as special. Now I have to check if it is a special hand, and it is not then do it by value. There is a NONE so we can use that instead.

travisby commented 10 years ago

schweet

travisby commented 10 years ago

testing

travisby commented 10 years ago

Good with the latest commits!

:shipit: