team401 / 2024-Robot-Code

Competition code for our 2024 robot
Other
7 stars 0 forks source link

add uptake banner sensor #163

Closed linglejack06 closed 7 months ago

linglejack06 commented 8 months ago

Summary: add sensor to uptake to prevent intake from running with note already in. This will prevent tech fouls.

Changes:

linglejack06 commented 8 months ago

@jkleiber this is the new pull request with a banner sensor in intake io class

PChild commented 8 months ago

We installed uptake note funnels today, those will be used to mount the uptake beam break which should be done tomorrow. The uptake beam break will low in the uptake (just above the intake rollers) so it should detect a note very early in the system and be effective for preventing two notes.

PChild commented 8 months ago

I think Justin closed the wrong one, feel free to re-close if not.

jkleiber commented 8 months ago

Yeah I closed the wrong one, thanks for catching that

linglejack06 commented 8 months ago

@jkleiber just updated logic to reflect what was reviewed

linglejack06 commented 8 months ago

sounds good

jkleiber commented 8 months ago

@linglejack06 can we add controller rumble to this PR for if the masher tries to intake while the robot thinks it already has a note?

linglejack06 commented 8 months ago

Yes I can add that to PR soon

jkleiber commented 7 months ago

closing this as I believe it was added in #179