search

teamdfir / sift-saltstack

Salt States for Configuring the SIFT Workstation
MIT License
96 stars 33 forks source link

Fix issue with setuptools causing crash #84

Closed digitalsleuth closed 1 year ago

digitalsleuth commented 1 year ago

Setuptools causes a crash during regular apt updates / upgrades because the semantic versioning of packages doesn't fit standard now enforced by setuptools above 66. Issue referenced here.

This PR will pin setuptools to any version under 66 until the issue is resolved.

digitalsleuth commented 1 year ago

For the record, this issue only occurs with Python 3.8 in Ubuntu 20.04

ekristen commented 1 year ago

We should probably split this into _focal vs _jammy salt states then so we can take different approaches. The old powershell or exfat extras has an example.

digitalsleuth commented 1 year ago

If we split them now while waiting for an issue to be resolved, we may find more incompatibility issues with future python3 tools if both OSes are using different versions of setuptools.

Since there's no deprecation planned for 65.x for a while, it might be better to keep both OSes at the same version to ensure compatibility while the issue gets resolved.

I can close the PR and make a new one, but I feel like this might be a better short-term approach.