merge LogTrainingHook and LogSessionHook?

tensorlab / tensorfx

TensorFlow framework for training and serving machine learning models

Apache License 2.0

196 stars 41 forks source link

merge LogTrainingHook and LogSessionHook? #5

Open brandondutra opened 7 years ago

brandondutra commented 7 years ago

LogSessionHook: shows time of last batch train, running total time, running throughput

LogTrainingHook: loss of last batch train, running total time, running throughput. Also makes summary events

Question: why do we run/have both? I basically see the same running total time, running throughput twice.

brandondutra commented 7 years ago

PR sent to remove the duplicated logging.

nikhilk commented 7 years ago

Lets consider WorkerLoggingHook and MasterLoggingHook where each generates a compact single log line -- goal is to show progress on each node in the cluster, with least possible impact on log.

brandondutra commented 7 years ago

See #13 for basic first pr.