tentone / nunuStudio

Web powered cross-platform 3D, WebXR game engine.
https://nunustudio.org
MIT License
2.09k stars 312 forks source link

PWA install compatibility #564

Closed glitch128 closed 9 months ago

glitch128 commented 9 months ago

Pull Request Template

Description

This allows the web editor to be installed as a PWA. what I added was a manifest link to the index.html file, a manifest.json file, two(2) .ico files and one(1) PNG file in a new "icons" folder

Fixes # (issue)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration I used GitHub pages to test the changes, and used developer tools to identify any errors

Checklist:

glitch128 commented 9 months ago

Ok, I forgot to change the start_url to "/editor/index.html" fixed now.

glitch128 commented 9 months ago

I changed the manifest description to "Web powered cross-platform 3D, WebXR game engine"

tentone commented 9 months ago

Thanks a lot for this contribution. LGTM.

Merged!

glitch128 commented 9 months ago

hey, I just installed the PWA, but it shows up like this on chromeOS image i tested changing the "property" attribute for the icons on replit, and the only way for it to work while also showing the "install" prompt is setting it to "any maskable", and it shows up like this image but I hear that doing this isn't recommended. Is it ok if I make it "any maskable"? also, here is the link to the repl https://nunustudio.glitch128.repl.co/docs/editor/index.html

edit: I just tried installing both pwas on my phone and the results are the same as on chromeOS. my phone is an android and I'm using the Lawnchair launcher.