search

teodosii / react-notifications-component

Delightful and highly customisable React Component to notify your users
https://teodosii.github.io/react-notifications-component/
MIT License
1.27k stars 73 forks source link

Pass classname and id to root component #31

Closed sradevski closed 4 years ago

sradevski commented 5 years ago

Fixes #30

teodosii commented 5 years ago

Why bother with otherProps when you could destructure this.props inside the two renderers? I will merge the PR only after this change.

teodosii commented 5 years ago

Also we need to update readme to let people know about the change, otherwise it's kinda pointless

sradevski commented 5 years ago

@teodosii addressed the comments, have another look at it

teodosii commented 5 years ago

Looks good, will merge it