terary / gabby-query-protocol-lib

Gabby Query Protocol - library
0 stars 0 forks source link

fix(validators): change signature to match parameter, exported from main package #14

Closed terary closed 3 years ago

terary commented 3 years ago

Signature were implementing generic interface, removed that so actual parameter list would be shown in IDE

fix #13 https://github.com/terary/gabby-query-protocol-lib/issues/13

CHANGELOG

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging e32f6e284c67c4e5510ca9f9fc60d1b4259e77fd into fa2a29e3273dd4055e05b573c85a02c706def20b - view on LGTM.com

new alerts:

codecov[bot] commented 3 years ago

Codecov Report

Merging #14 (527e0b7) into main (fa2a29e) will increase coverage by 0.12%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   98.13%   98.26%   +0.12%     
==========================================
  Files          39       39              
  Lines         806      806              
  Branches      141      141              
==========================================
+ Hits          791      792       +1     
+ Misses         15       14       -1     
Flag Coverage Δ
unittests 98.26% <100.00%> (+0.12%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/validators/index.ts 100.00% <ø> (ø)
src/index.ts 100.00% <100.00%> (ø)
src/validators/NoSingleChildRule.ts 100.00% <100.00%> (+9.09%) :arrow_up:
...validators/ValidateAllPredicatesAgainstOperator.ts 100.00% <100.00%> (ø)
src/validators/ValidatePredicateAgainstOperator.ts 97.05% <100.00%> (ø)
src/validators/ValidateSubjectDictionary.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fa2a29e...527e0b7. Read the comment docs.

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert when merging 34c04bae8c9c43c67397737da4aadc7ee00be89b into fa2a29e3273dd4055e05b573c85a02c706def20b - view on LGTM.com

new alerts: