terary / gabby-query-protocol-lib

Gabby Query Protocol - library
0 stars 0 forks source link

Factory consistency from*(...) #53

Open terary opened 2 years ago

terary commented 2 years ago

https://github.com/terary/gabby-query-protocol-lib/blob/9b468ee3a27ce6a88ab0d49b62cee0c179f0752e/src/PredicateFormulaEditor/PredicateFormulaEditorFactory.ts#L8

sometimes .from(...) is called with arguments and sometimes with single object as argument fromEmpty( subjects, initialRoot) fromJson({subject:..., predicateTre:...}) Should consistently call with object so parameters can be named