search

tesseract-robotics / tesseract_qt

Tesseract Qt Widgets and Applications
GNU Lesser General Public License v3.0
11 stars 10 forks source link

Fix clang format for newer versions #102

Closed smith-doug closed 4 months ago

smith-doug commented 4 months ago

This works for me with clang-format-14 on 22.04

After https://github.com/tesseract-robotics/tesseract_qt/pull/101

Levi-Armstrong commented 4 months ago

Can we pin it to the highest version available on 20.04?

rjoomen commented 4 months ago

LGTM, I've been using this for a while already with a recent clang-tidy.

Levi-Armstrong commented 4 months ago

It looks like you can install version 14 on 20.04 so I would just pin the scripts to version 14. This way it forces every one to use the desired version.

smith-doug commented 4 months ago

Sorry if I notified the wrong person. I haven't used the review features on github much. Both changes were made.