tesseract-robotics / tesseract_qt

Tesseract Qt Widgets and Applications
GNU Lesser General Public License v3.0
11 stars 10 forks source link

Gazebo Rendering Dependencies #47

Closed marrts closed 10 months ago

marrts commented 1 year ago

I was updating to the latest version to run things in ROS and had to update my apt repository for the latest gazebo packages for rendering. Could the rendering and studio code be shifted to the https://github.com/tesseract-robotics/tesseract_gui package so that we don't have these unnecessary dependencies if we just want to use the RVIZ interface?

Levi-Armstrong commented 1 year ago

The intent of tesseract is to be ros agnostic so the rendering provided in tesseract_qt is what I consider the default for tesseract moving forward. The tesseract_gui will be deprecated/archived soon.

marrts commented 1 year ago

I understand the convenience of having the interface that is completely separated from ROS and the convenience of the widgets and that interface being developed in the same package, but it seems like in the current implementation it is coming at a cost of making running it with ROS more complicated, which I think should also be straight forward to do. I ran into issues updating and I see this issue as well, so I suspect I won't be the last. In my head I see the layout as:

Core Functionality

Levi-Armstrong commented 1 year ago

This issue only popped up because this is using a new release of gazebo but the packages have not been added to rosdep. After these have been release in ros, things should also work as normal.

If you don't want the added dependency then I would be fine with adding a CMake option to disable building these components in this package. I am not a fan of using separate package or repositories to separate dependencies because this is a ROS limitation not a Ubuntu Debian or Windows packaging limitation.