test-fullautomation / robotframework-robotlog2db

2 stars 1 forks source link

Ntd1hc/feat/enhance robotlog2db tool #36

Closed ngoan1608 closed 1 year ago

ngoan1608 commented 1 year ago

Hi Holger, Hi Thomas,

This changes in this PR are aligned with changes in PyTestLog2DB repos.

Please review the functionalities of the changes. I am updating document accordingly.

Thank you, Ngoan

ngoan1608 commented 1 year ago

Line _tbl_case_component = metadata_info['component']

causes crash (key error 'component').

Hi Holger,

This is my fault, I have pushed 2 last commits which fixed this issue into personal remote instead of this repo. I have just pushed them to this repo. Please pull the latest changes and help me to double-check.

Thank you, Ngoan

HolQue commented 1 year ago

Hi Ngoan,

works fine now!

ngoan1608 commented 1 year ago

Hi Holger,

I have added new commits to implement a validation of xmlresultfile with robot result schema (robot.xsd file) which you mentioned in issue #26. The xml result file(s) will be validated at the first step so it will avoid such errors related to result when importing.

The schema robot.xsd is updated with the new UNKNOWN state (implemented by us in robotframework core) so that the xml result which is generated by RobotRramework AIO should work properly.

Please help to double-check the changes.

Thank you, Ngoan

ngoan1608 commented 1 year ago

Issue #25 is also fixed with new commits.

HolQue commented 1 year ago

Hi Ngoan,

you need to extend the

"PACKAGEDATA" : ["*.pdf"],

by

"PACKAGEDATA" : ["*.pdf","./xsd/*.xsd"],

to get the xsd file installed also ;-)

HolQue commented 1 year ago

And unfortunately an XML syntax error still causes a crash:

lxml.etree.XMLSyntaxError: Opening and ending tag mismatch: testsuitesXYZ line 1 and testsuites, line 1, column 19500

You need to use try/except when opening an XML file.

test-fullautomation commented 1 year ago

Hi Ngoan,

I overlooked the finding from Holger at the end. Please create a new pull-request for this issue.

Thank you, Thomas