search

testinprod-io / op-erigon

Optimism implementation on the efficiency frontier
https://op-erigon.testinprod.io
GNU Lesser General Public License v3.0
86 stars 15 forks source link

[Fjord] Add FastLZ compression into L1CostFunc + Refactor #177

Closed pcw109550 closed 4 months ago

pcw109550 commented 4 months ago

Mirror https://github.com/ethereum-optimism/op-geth/pull/249

ImTei commented 4 months ago

Looks good 👍 but we have few things to deduplicate and cleanup code. In erigon-lib/opstack/rollup_cost.go,

pcw109550 commented 4 months ago

Looks good 👍 but we have few things to deduplicate and cleanup code. In erigon-lib/opstack/rollup_cost.go,

  • extractL1GasParamsPreEcotone and extractL1GasParamsPostEcotone have some duplicated lines with extractL1GasParamsLegacy and extractL1GasParamsEcotone. we can reuse code.
  • New L1 cost logic must be applied to existing other methods: L1Cost, l1CostHelper, L1CostFnForTxPool

Fixed at https://github.com/testinprod-io/op-erigon/pull/179